[Mesa-dev] [PATCH 1/2] mesa: implement AMD_seamless_cubemap_per_texture

[Marek Olšák]

On Tue, May 3, 2011 at 11:21 PM, Brian Paul <brianp at vmware.com> wrote:
>  On 05/03/2011 01:24 PM, Brian Paul wrote:
>>
>> On 05/03/2011 07:55 AM, Marek Olšák wrote:
>>>
>>> ---
>>>  src/mesa/main/extensions.c |    1 +
>>>  src/mesa/main/mtypes.h     |    2 ++
>>>  src/mesa/main/texobj.c     |    2 ++
>>>  src/mesa/main/texparam.c   |   32 ++++++++++++++++++++++++++++++++
>>>  4 files changed, 37 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
>>> index 1062cde..a9ef8fa 100644
>>> --- a/src/mesa/main/extensions.c
>>> +++ b/src/mesa/main/extensions.c
>>> @@ -260,6 +260,7 @@ static const struct extension extension_table[] = {
>>>     { "GL_3DFX_texture_compression_FXT1",
>>> o(TDFX_texture_compression_FXT1),           GL,             1999 },
>>>     { "GL_AMD_conservative_depth",
>>>  o(AMD_conservative_depth),                  GL,             2009 },
>>>     { "GL_AMD_draw_buffers_blend",
>>>  o(ARB_draw_buffers_blend),                  GL,             2009 },
>>> +   { "GL_AMD_seamless_cubemap_per_texture",
>>>  o(AMD_seamless_cubemap_per_texture),        GL,             2009 },
>>>     { "GL_AMD_shader_stencil_export",
>>> o(ARB_shader_stencil_export),               GL,             2009 },
>>>     { "GL_APPLE_client_storage",
>>>  o(APPLE_client_storage),                    GL,             2002 },
>>>     { "GL_APPLE_object_purgeable",
>>>  o(APPLE_object_purgeable),                  GL,             2006 },
>>> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
>>> index fba65e8..ad65b55 100644
>>> --- a/src/mesa/main/mtypes.h
>>> +++ b/src/mesa/main/mtypes.h
>>> @@ -1370,6 +1370,7 @@ struct gl_texture_object
>>>     GLint CropRect[4];           /**<  GL_OES_draw_texture */
>>>     GLenum Swizzle[4];           /**<  GL_EXT_texture_swizzle */
>>>     GLuint _Swizzle;             /**<  same as Swizzle, but SWIZZLE_*
>>> format */
>>> +   GLboolean CubeMapSeamless;   /**<
>>>  GL_AMD_seamless_cubemap_per_texture */
>>
>> I'm wondering if this field should be per-texture object or per-sampler
>> object.  I've sent an email to someone at AMD to find out.  I'll let you
>> know.
>>
>
> It's supposed to be per sampler object.

OK, thanks for info.

Marek