[Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec

Jesse Barnes jbarnes at virtuousgeek.org
Wed May 4 17:54:48 PDT 2011

On Wed, 4 May 2011 17:49:37 -0700
Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> How about you look at git and see what happened last time?
> We added some dri2 proto requests, and people wanted to build with old
> versions w/o the new requests.  So they added some ifdefs but didn't
> check all the combos (now not just old server/new server, but
> multiplied by two) and things were broken for awhile, and it was easy
> to get breakage without even noticing (I found several bugs for people
> related to invalidation that were solely due to bad builds).

(For those who don't want to look through git and the history: the
problem is that making the builds use old and new means you can build
client and server with different proto versions and not even notice.
That makes debugging all the harder because everything seems to be ok
but you're now taking untested paths on the client and/or server side
due to #ifdefs and protocol mismatches.)

Jesse Barnes, Intel Open Source Technology Center

More information about the mesa-dev mailing list