[Mesa-dev] [PATCH] xserver/glx/dri2: use new GLX/DRI2 swap event types

Jesse Barnes jbarnes at virtuousgeek.org
Thu May 5 14:02:32 PDT 2011

> >    if (swap_complete) {
> >        if (pPriv->swap_count > 0xffffffff)
> >            ErrorF("something appropriate");
> >        swap_complete(client, swap_data, type, ust, frame, (CARD32)pPriv->swap_count);
> >    }
> Yeah, it's annoying.  How about I leave out the error message and handle
> wrapping on the client side instead?  That way at least the client code
> won't notice that the server is only transmitting 32 bits...

Nevermind, that can't work generally since clients are free to
mask/unmask the events, so we could miss a 0 count and thus a wrap.  We
just have to live with the fact that swap events have a 32 bit sbc and
OML uses 64 bit counts.  I'll add the warning though; if it becomes a
real issue we can potentially add another round trip to get the value
using OML instead.

Jesse Barnes, Intel Open Source Technology Center

More information about the mesa-dev mailing list