[Mesa-dev] Status of VDPAU and XvMC state-trackers (was Re: Build error on current xvmc-r600 pipe-video)

[Alex Deucher]

2011/5/5 Christian König <deathsimple at vodafone.de>:
> Am Donnerstag, den 05.05.2011, 12:11 +0100 schrieb Andy Furniss:
>> Andy Furniss wrote:
>> > There has been a regression though -
>> >
>> > [g3dvl] remove resource_format workaround
>> >
>> > causes quite bad artifacts on newmobcal.
>>
>> I can get rid of the new artifacts for xvmc with the patch below.
>>
>> ffmpeg12vdpau shows the same "new" artifacts, but is not fixed by this.
> The problem is more complicated than this, using a signed buffer format
> is just a workaround, the real solution is to implement blender clamping
> in r600g. You could try this (temporary) patch until I figured out how
> to do this correctly on all supported hardware:

Something like the attached patch should work.

Alex


>
> --- a/src/gallium/drivers/r600/r600_state.c
> +++ b/src/gallium/drivers/r600/r600_state.c
> @@ -786,10 +786,10 @@ static void r600_cb(struct r600_pipe_context *rctx, struct r600_pipe_state *rsta
>           if BLEND_FLOAT32 is set of > 11 bits in a UNORM or SNORM */
>        if (desc->colorspace != UTIL_FORMAT_COLORSPACE_ZS && desc->channel[i].size < 12) {
>                //TODO: Seems to work on RV710, but i have no idea what to do between R600-RV710
> -               if (rctx->family < CHIP_RV710) {
> -                       color_info |= S_0280A0_BLEND_CLAMP(1);
> -                       color_info_mask |= S_0280A0_BLEND_CLAMP(1);
> -               }
> +               //if (rctx->family < CHIP_RV710) {
> +               //      color_info |= S_0280A0_BLEND_CLAMP(1);
> +               //      color_info_mask |= S_0280A0_BLEND_CLAMP(1);
> +               //}
>                color_info |= S_0280A0_SOURCE_FORMAT(V_0280A0_EXPORT_NORM);
>        }
>
> I'm currently focusing more on the variable length decoding part of the
> vdpau mpeg2, by the way: How is well does this work on your hardware?
>
> Regards,
> Christian.
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-r600g-fix-up-the-rules-for-enabling-SOURCE_FORMAT-EX.patch
Type: text/x-patch
Size: 4134 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110505/8e9abb0c/attachment.bin>