[Mesa-dev] [PATCH] st/mesa: overhaul vertex/fragment sampler and sampler views.

[Julian Adams]

The bug I reported was:
https://bugs.freedesktop.org/show_bug.cgi?id=35849, which contained
the patch to add the fragment-and-vertex-texturing test. It sounds
like this patch fixes that bug :) I was using the r600g driver.

On 15 May 2011 17:45, Brian Paul <brian.e.paul at gmail.com> wrote:
> On Sun, May 15, 2011 at 1:55 AM, Dave Airlie <airlied at gmail.com> wrote:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> This fixes piglits fragment-and-vertex-texturing test on llvmpipe for me.
>>
>> I've no idea if someone had another plan for this that is smarter than what
>> I've done here, but what I've basically done is
>>
>> split fragment and vertex sampler and sampler_view setup function, factor
>> out the common chunks of both.
>>
>> side-cleanups:
>> drop st->state.sampler_list - unused
>> don't update border color if we have no border color.
>
> I only took a quick look but this seems right.  I think there's an
> open bug related to mishandling of sampler state from a couple months
> ago (you might want to look that one up and test for it).  My
> suggestion then was to split up the loop into separate vertex/fragment
> loops like this.
>
> Reviewed-by: Brian Paul <brianp at vmware.com>
>
> -Brian
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>