[Mesa-dev] [PATCH] mesa: Use signed math for possibly negative values

Adam Jackson ajax at redhat.com
Thu May 19 11:34:48 PDT 2011

On Thu, 2011-05-19 at 14:13 +0200, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> Since RowStride might be negative, we want a signed result.  On 64-bit
> platforms, an unsigned 32-bit result added to a 64-bit pointer will
> give the wrong answer.

Hah, saw this just as I sent my patch.  Let's hear it for communication.

This is less intrusive than mine, but I think mine's preferable, unless
we're sure all other users of _mesa_get_format_bytes() are correct.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110519/a39cefdb/attachment.pgp>

More information about the mesa-dev mailing list