[Mesa-dev] [PATCH] glproto: add a new GLXBufferSwapComplete struct that matches the spec

[Jesse Barnes]

On Tue, 10 May 2011 17:57:52 -0700
Eric Anholt <eric at anholt.net> wrote:

> On Tue, 10 May 2011 12:32:24 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> > On Tue, 10 May 2011 11:59:56 -0700
> > Eric Anholt <eric at anholt.net> wrote:
> > 
> > > On Thu, 5 May 2011 12:39:57 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> > > > Just add a new struct to remain compatible with existing code.
> > > > 
> > > > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> > > > 
> > > > diff --git a/configure.ac b/configure.ac
> > > > index a3047e4..a6c301c 100644
> > > > --- a/configure.ac
> > > > +++ b/configure.ac
> > > > @@ -1,5 +1,5 @@
> > > >  AC_PREREQ([2.60])
> > > > -AC_INIT([GLProto], [1.4.13], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg])
> > > > +AC_INIT([GLProto], [1.4.14], [https://bugs.freedesktop.org/enter_bug.cgi?product=xorg])
> > > >  AM_INIT_AUTOMAKE([foreign dist-bzip2])
> > > >  AM_MAINTAINER_MODE
> > > >  
> > > > diff --git a/glxproto.h b/glxproto.h
> > > > index dfa0647..3f9e837 100644
> > > > --- a/glxproto.h
> > > > +++ b/glxproto.h
> > > > @@ -1375,6 +1375,20 @@ typedef struct {
> > > >      BYTE pad;
> > > >      CARD16 sequenceNumber B16;
> > > >      CARD16 event_type B16;
> > > 
> > > While this is the compat structure, I'd still like to see the padding
> > > explicit so I don't worry about it when reading the code ever again.
> > 
> > Ok, wanna push your existing patch for that or should I push it with
> > this stuff?
> 
> Meh, just push it with your stuff.

Ok, I've just pushed the dri2proto and glproto changes.  I'd appreciate
some testing besides myself before pushing the mesa bits though (which
work with both old and new X servers, so the delay in getting the X
bits merged should be fine).

There's a glx-swap-event test in piglit I've been using.  The -v option
will give you counts, and you can edit the server to start at a high
swap count to test the wrapping.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center