[Mesa-dev] [PATCH]: global forcing anisotropy

[Michel Dänzer]

On Fre, 2011-05-20 at 16:22 +0200, Carl-Philip Haensch wrote: 
> Zitat von Michel Dänzer <michel at daenzer.net>:
> 
> >> diff --git a/src/gallium/state_trackers/dri/common/dri_context.c   
> >> b/src/gallium/state_trackers/dri/common/dri_context.c
> >> index e23c1bc..73ac43b 100644
> >> --- a/src/gallium/state_trackers/dri/common/dri_context.c
> >> +++ b/src/gallium/state_trackers/dri/common/dri_context.c
> >> @@ -37,6 +37,7 @@
> >>
> >>  #include "pipe/p_context.h"
> >>  #include "state_tracker/st_context.h"
> >> +#include "state_tracker/drm_driver.h"
> >>
> >>  static void
> >>  dri_init_extensions(struct dri_context *ctx)
> >> @@ -86,8 +87,8 @@ dri_create_context(gl_api api, const struct   
> >> gl_config * visual,
> >>     ctx->lock = screen->drmLock;
> >>
> >>     driParseConfigFiles(&ctx->optionCache,
> >> -                      &screen->optionCache, sPriv->myNum, "dri");
> >> -
> >> +                      &screen->optionCache, sPriv->myNum,   
> >> driver_descriptor.name);
> >
> > This should probably be a separate fix.
> >
> 
> I attached it as a patch for applying.

[...]

> Subject: [PATCH] gallium/st: Use driver name to access driconf. This
> fixes fetching driconf options from the gallium drivers.

Git convention is to use a single line short summary (all Git related
tools use the first line of the commit message as the short summary),
followed by an empty line and the rest of the description.

Mesa convention is to prefix changes affecting Gallium state tracker foo
with 'st/foo:'.


> diff --git a/src/gallium/state_trackers/dri/common/dri_context.c
> b/src/gallium/state_trackers/dri/common/dri_context.c
> index e23c1bc..d399534 100644
> --- a/src/gallium/state_trackers/dri/common/dri_context.c
> +++ b/src/gallium/state_trackers/dri/common/dri_context.c
> @@ -37,6 +37,7 @@
>  
>  #include "pipe/p_context.h"
>  #include "state_tracker/st_context.h"
> +#include "state_tracker/drm_driver.h"
>  
>  static void
>  dri_init_extensions(struct dri_context *ctx)
> @@ -85,8 +86,8 @@ dri_create_context(gl_api api, const struct
> gl_config * visual,
>     ctx->sPriv = sPriv;
>     ctx->lock = screen->drmLock;
>  
> -   driParseConfigFiles(&ctx->optionCache,
> -                      &screen->optionCache, sPriv->myNum, "dri");
> +   driParseConfigFiles(&ctx->optionCache, &screen->optionCache, 

This line introduces a trailing space. Git should have warned about
that.

> +                        sPriv->myNum, driver_descriptor.name);

Also, unfortunately these changes breaks the swrastg build for me due to
an undefined reference to 'driver_descriptor'.

Last but not least, I haven't been able to tell any difference between
using driconf with this patch applied vs. not with r600g. Can you
elaborate a little more on how exactly the problem manifests itself, and
how to verify that it's fixed?


-- 
Earthling Michel Dänzer           |                http://www.vmware.com
Libre software enthusiast         |          Debian, X and DRI developer