[Mesa-dev] [PATCH 01/18] i965: Fix assertion failures in unused brw_reg setup by deleting it.

Kenneth Graunke kenneth at whitecape.org
Wed May 25 10:46:28 PDT 2011


On 05/24/2011 04:00 PM, Eric Anholt wrote:
> I was using undefined values to create an unused value.  Go me.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=37366
> ---
>   src/mesa/drivers/dri/i965/brw_fs.cpp |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
> index 6d545af..a4adb17 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> @@ -2743,7 +2743,6 @@ fs_visitor::generate_discard(fs_inst *inst)
>         brw_pop_insn_state(p);
>      } else {
>         struct brw_reg g0 = retype(brw_vec1_grf(0, 0), BRW_REGISTER_TYPE_UW);
> -      struct brw_reg mask = brw_uw1_reg(mask.file, mask.nr, 0);
>
>         brw_push_insn_state(p);
>         brw_set_mask_control(p, BRW_MASK_DISABLE);

Patches 1-3, 6-8, and 16-18 are:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list