[Mesa-dev] Fixing webgl crashes

[Benoit Jacob]

----- Original Message -----
> This is a series to fix our Firefox WebGL crashes. Their debug code,
> which they do nightly testing on, uses a debug mode which calls
> glFinish() after every operation. That revealed failures in our
> glFinish() implementation.

Thumbs up!

Just FYI --- the nightly testing doesn't run with MOZ_GL_DEBUG=1 (the special debug mode that calls glFinish() after every GL call).

Benoit

> 
> I'm not really pleased with the state handling for
> _ColorDrawBuffers[]. Non-refcounted pointers to refcounted objects
> fill me with rage (after filling my bugzilla with crashes). This is
> sort of the minimal patch, while I think a more invasive patch would
> be to remove _ColorDrawBuffers[] and just give people an accessor
> function using _ColorDrawIndexes[] which are the indexes into
> Attachments[] that are updated immediately upon glDrawBuffers().
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev