[Mesa-dev] [PATCH] Fix glXGetFBConfigFromVisualSGIX.

[Brian Paul]

On 05/26/2011 06:19 PM, Stéphane Marchesin wrote:
> From: Stéphane Marchesin<marcheu at chromium.org>
>
> We want to check for Success, otherwise it will fail even with the right visual.
>
> NOTE: This is a candidate for the 7.10 branch.
>
> Signed-off-by: Antoine Labour<piman at chromium.org>
> Signed-off-by: Stéphane Marchesin<marcheu at chromium.org>
> ---
>   src/glx/glxcmds.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/glx/glxcmds.c b/src/glx/glxcmds.c
> index 012cd79..dbfa0ed 100644
> --- a/src/glx/glxcmds.c
> +++ b/src/glx/glxcmds.c
> @@ -1890,7 +1890,7 @@ glXGetFBConfigFromVisualSGIX(Display * dpy, XVisualInfo * vis)
>      struct glx_display *priv;
>      struct glx_screen *psc = NULL;
>
> -   if ((GetGLXPrivScreenConfig(dpy, vis->screen,&priv,&psc) != Success)
> +   if ((GetGLXPrivScreenConfig(dpy, vis->screen,&priv,&psc) == Success)
>          &&  __glXExtensionBitIsEnabled(psc, SGIX_fbconfig_bit)
>          &&  (psc->configs->fbconfigID != (int) GLX_DONT_CARE)) {
>         return (GLXFBConfigSGIX) glx_config_find_visual(psc->configs,

Looks good, will commit soon.

-Brian