[Mesa-dev] [PATCH] winsys: fill in missing displaytarget bits in null winsys

[Jose Fonseca]

----- Original Message -----
> This is needed for renderbuffer support.

What state tracker relies on this?

I don't object this change, but it sounds like you should be using a proper sw winsys, instead of null winsys.  The null winsys can't really display anything, so the current implementation is more honest.

> ---
>  src/gallium/winsys/sw/null/null_sw_winsys.c |   52
>  +++++++++++++++++++++++----
>  1 files changed, 45 insertions(+), 7 deletions(-)
> 
> diff --git a/src/gallium/winsys/sw/null/null_sw_winsys.c
> b/src/gallium/winsys/sw/null/null_sw_winsys.c
> index 73b777f..4af2e2b 100644
> --- a/src/gallium/winsys/sw/null/null_sw_winsys.c
> +++ b/src/gallium/winsys/sw/null/null_sw_winsys.c
[...]
>  
> @@ -74,7 +89,9 @@ static void
>  null_sw_displaytarget_destroy(struct sw_winsys *winsys,
>                                struct sw_displaytarget *dt)
>  {
> -   assert(0);
> +   struct null_displaytarget *null_dt = (struct null_displaytarget
> *)dt;
> +   FREE(null_dt->data);

FREE -> align_free


> +   FREE(null_dt);
>  }
>  
>  



Jose