[Mesa-dev] [PATCH] mesa: fix glTexSubImage bugs in compressed texture code

Brian Paul brianp at vmware.com
Thu Oct 6 14:02:24 PDT 2011


On 10/06/2011 02:38 PM, Eric Anholt wrote:
> On Wed,  5 Oct 2011 20:57:24 -0600, Brian Paul<brian.e.paul at gmail.com>  wrote:
>> From: Brian Paul<brianp at vmware.com>
>>
>> This fixes failures found with the new piglit texsubimage test.
>>
>> Two things were broken:
>> 1. The dxt code doesn't handle sources images where width != row stride.
>>     Check for that and take the _mesa_make_temp_ubyte_image() path to get
>>     an image where width = rowstride.
>> 2. If we don't take the _mesa_make_temp_ubyte_image() path we need to
>>     take the source image unpacking parameters into account in order to
>>     get the proper starting memory address of the source texels.
>
> Perhaps call it "fix compressed glTexSubImage for with non-default
> unpack params"?  It looked like two separate patches until I realized
> both were about unpack twiddling.

I can do that.  Is that a Reviewed-by?

-Brian



More information about the mesa-dev mailing list