[Mesa-dev] [PATCH 1/2] swrast: Fix fastpaths in glRead/WritePixels(GL_DEPTH_STENCIL)

[Brian Paul]

On Mon, Oct 10, 2011 at 7:10 PM, Chad Versace <chad at chad-versace.us> wrote:
> For glReadPixels, the user supplied pixels have format
> GL_UNSIGNED_INT_24_8.  But, when the depthstencil buffer's format was
> MESA_FORMAT_S8_Z24, the fastpath read from the buffer without reordering
> the depth and stencil bits. To fix this, this patch just skips the
> fastpath when the format is not MESA_FORMAT_Z24_S8.
>
> The problem and fix for glWritePixels is analagous.
>
> Fixes the Piglit tests below on i965/gen6 and causes no regressions.
>   general/depthstencil-default_fb-drawpixels-24_8
>   general/depthstencil-default_fb-readpixels-24_8
>   EXT_packed_depth_stencil/fbo-depthstencil-GL_DEPTH24_STENCIL8-drawpixels-24_8
>   EXT_packed_depth_stencil/fbo-depthstencil-GL_DEPTH24_STENCIL8-readpixels-24_8
>
> Signed-off-by: Chad Versace <chad at chad-versace.us>

Reviewed-by: Brian Paul <brianp at vmware.com>