[Mesa-dev] [PATCH 3/6] mesa: check attachment Type field in renderbuffer_exists()

[Eric Anholt]

On Mon, 10 Oct 2011 21:05:33 -0600, Brian Paul <brian.e.paul at gmail.com> wrote:
> From: Brian Paul <brianp at vmware.com>
> 
> Instead of the renderbuffer pointer.  In the future, attaching a texture
> may not mean the renderbuffer pointer gets set too.
> Plus, remove some commented-out assertions.

I'm curious where you're going with not having a Renderbuffer for
textures.  I've wished that Mesa core handled making a Renderbuffer for
textures, since there was this ugly driver code for cooking up a
Renderbuffer even though everyone's should be basically the same.

Maybe having the Renderbuffer go away will help, I'm not sure.  In the
rbmapping in swrast, I'm constantly wanting to know the format of
fb->Attachments[WHATEVER] and get a mapping of it.  I think that's the
most important to have easy access to, whether it's from the
Renderbuffer or helper functions on the attachment point (but it's sure
easier to be able to pass a gl_renderbuffer around than fb+attachment).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111012/ad94d9e5/attachment.pgp>