[Mesa-dev] [PATCH 4/4] mesa, intel: use _mesa_image_offset() for PBOs

Brian Paul brianp at vmware.com
Wed Oct 19 07:20:27 PDT 2011


On 10/19/2011 06:03 AM, nobled wrote:
> This avoids forming invalid pointers needlessly, which even if
> never dereferenced is undefined behavior. It also makes
> _mesa_validate_pbo_access() more comprehensible.

Reviewed-by: Brian Paul <brianp at vmware.com>

BTW, be sure to test these changes with the glean pbo test.  It covers 
quite a few cases.

-Brian


More information about the mesa-dev mailing list