[Mesa-dev] [PATCH] mesa: handle PBO access error in display list mode

[Brian Paul]

On 10/18/2011 09:20 PM, Yuanhan Liu wrote:
> Simply generate GL_INVALID_OPERATION error at display list mode. As
> explained by Brian, we are going to access PBO data at compile time.
> No need to defer the error at execution time.
>
> Signed-off-by: Yuanhan Liu<yuanhan.liu at linux.intel.com>
> ---
>   src/mesa/main/dlist.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c
> index 625649e..d901bdd 100644
> --- a/src/mesa/main/dlist.c
> +++ b/src/mesa/main/dlist.c
> @@ -939,7 +939,9 @@ unpack_image(struct gl_context *ctx, GLuint dimensions,
>         }
>         return image;
>      }
> +
>      /* bad access! */
> +   _mesa_error(ctx, GL_INVALID_OPERATION, "invalid PBO access");
>      return NULL;
>   }
>

Reviewed-by: Brian Paul <brianp at vmware.com>