[Mesa-dev] [PATCH] Only use gcc visibility support with gcc4+.

[Brian Paul]

On 10/19/2011 02:44 PM, Tom Fogal wrote:
> I had a colleague hitting issues compiling with an old gcc3.2
> system.  These patches got them through.
> ---
>   include/GL/gl.h          |    2 +-
>   src/mesa/main/compiler.h |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/GL/gl.h b/include/GL/gl.h
> index 998a83a..e65e1bc 100644
> --- a/include/GL/gl.h
> +++ b/include/GL/gl.h
> @@ -67,7 +67,7 @@
>   #elif defined(__CYGWIN__)&&  defined(USE_OPENGL32) /* use native windows opengl32 */
>   #  define GLAPI extern
>   #  define GLAPIENTRY __stdcall
> -#elif defined(__GNUC__)	|| (defined(__SUNPRO_C)&&  (__SUNPRO_C>= 0x590))
> +#elif (defined(__GNUC__)&&  __GNUC__>= 4) || (defined(__SUNPRO_C)&&  (__SUNPRO_C>= 0x590))
>   #  define GLAPI __attribute__((visibility("default")))
>   #  define GLAPIENTRY
>   #endif /* WIN32&&  !CYGWIN */
> diff --git a/src/mesa/main/compiler.h b/src/mesa/main/compiler.h
> index 89d6cda9..921e302 100644
> --- a/src/mesa/main/compiler.h
> +++ b/src/mesa/main/compiler.h
> @@ -150,7 +150,7 @@ extern "C" {
>    * inline a static function that we later use in an alias. - ajax
>    */
>   #ifndef PUBLIC
> -#  if defined(__GNUC__) || (defined(__SUNPRO_C)&&  (__SUNPRO_C>= 0x590))
> +#  if (defined(__GNUC__)&&  __GNUC__>= 4) || (defined(__SUNPRO_C)&&  (__SUNPRO_C>= 0x590))
>   #    define PUBLIC __attribute__((visibility("default")))
>   #    define USED __attribute__((used))
>   #  else


Reviewed-by: Brian Paul <brianp at vmware.com>