[Mesa-dev] [PATCH 1/2] Fix gcc version checks for _mesa_bitcount

Kenneth Graunke kenneth at whitecape.org
Fri Oct 21 17:11:41 PDT 2011


On 10/21/2011 04:10 PM, Alan Coopersmith wrote:
> - Fix _GNUC__ typo in both checks
> - Fix logic error in check for gcc < 3.4 that breaks for gcc 2.x & older
> 
> Without this fix, builds with gcc 3.4.x end up depending on undefined
> _mesa_bitcount instead of gcc's __builtin_popcount.
> 
> NOTE: This is a candidate for the stable branches.
> 
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>

For both patches:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Thanks, Alan.


More information about the mesa-dev mailing list