[Mesa-dev] [PATCH 03/33] i965: Add a note about an unsafe-looking state check.

Eric Anholt eric at anholt.net
Mon Oct 24 14:16:50 PDT 2011


---
 src/mesa/drivers/dri/i965/brw_draw.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
index c02b2bc..c3755d5 100644
--- a/src/mesa/drivers/dri/i965/brw_draw.c
+++ b/src/mesa/drivers/dri/i965/brw_draw.c
@@ -350,6 +350,11 @@ static bool brw_try_draw_prims( struct gl_context *ctx,
       else
 	 gen6_set_prim(brw, &prim[i]);
 
+      /* Note that before the loop, brw->state.dirty.brw was set to != 0, and
+       * that the state updated in the loop outside of this block is that in
+       * *_set_prim or intel_batchbuffer_flush(), which only impacts
+       * brw->state.dirty.brw.
+       */
       if (brw->state.dirty.brw) {
 	 brw_validate_state(brw);
 
-- 
1.7.7



More information about the mesa-dev mailing list