[Mesa-dev] [PATCH] intel: Kill dead code in intel_miptree_copy_teximage()

[Eric Anholt]

On Mon, 24 Oct 2011 14:03:38 -0700, Chad Versace <chad at chad-versace.us> wrote:
> Kill the code paths taken when src_mt is null. It is never null, otherwise
> there would be a segfault on line 4 of this function:
>     GLuint width = src_mt->level[level].width;
> 
> (Some interleaved lines in the diff make the real diff non-obvious. All
> I did was delete some code and then left-shifted what remained to correct
> the indentation.)
> 
> Signed-off-by: Chad Versace <chad at chad-versace.us>

I was going to say how this was incorrect and must have been something I
broke in my refactor, but these days the only way to not have an mt is
with texture borders, and with texture borders we don't call this
function anyway.

It is a good reminder to me to send out the strip-texture-borders code,
though.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111024/c8865a7f/attachment.pgp>