[Mesa-dev] [PATCH 4/7] gallium: add IA88 and AI88 indexed formats.

[Jose Fonseca]

----- Original Message -----
> They are mostly used for menu overlay.
> 
> Signed-off-by: Christian König <deathsimple at vodafone.de>
> ---
>  src/gallium/auxiliary/util/u_format.csv |    2 ++
>  src/gallium/include/pipe/p_format.h     |    6 ++++--
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/src/gallium/auxiliary/util/u_format.csv
> b/src/gallium/auxiliary/util/u_format.csv
> index b1a85a5..d596d4b 100644
> --- a/src/gallium/auxiliary/util/u_format.csv
> +++ b/src/gallium/auxiliary/util/u_format.csv
> @@ -269,3 +269,5 @@ PIPE_FORMAT_NV21                  , other, 1, 1,
> x8  , x8  , x8  , x8  , xyzw, y
>  # Indexed with Alpha
>  PIPE_FORMAT_IA44                  , plain, 1, 1, un4 , un4 ,     ,      , y00x, rgb
>  PIPE_FORMAT_AI44                  , plain, 1, 1, un4 , un4 ,     ,      , x00y, rgb
> +PIPE_FORMAT_IA88                  , plain, 1, 1, un8 , un8 ,     ,      , x00y, rgb
> +PIPE_FORMAT_AI88                  , plain, 1, 1, un8 , un8 ,     ,      , y00x, rgb
 
Christian,

There are a few inconsistentcies here.

-  The swizzles of IA88 and IA44 don't pair. Ditto for AI88/IA88.

-  It doesn't look like a typical intensity -- if so then RGB should have the same swizzle instead of "x00", and "y00". So either put a "xxx" or "yyy" RGB swizzles, or rename these to RA44/AR44/RA88/AR88/etc.

Otherwise the series looks good.

Jose