[Mesa-dev] [PATCH 4/8] intel: add support for __DRI_IMAGE_FORMAT_RGBA8888_REV

[Eric Anholt]

On Fri, 2 Sep 2011 11:58:45 +0800, Chia-I Wu <olvaffe at gmail.com> wrote:
> On Fri, Sep 2, 2011 at 4:09 AM, Eric Anholt <eric at anholt.net> wrote:
> > On Wed, 31 Aug 2011 13:46:35 +0800, Chia-I Wu <olvaffe at gmail.com> wrote:
> >> From: Chia-I Wu <olv at lunarg.com>
> >>
> >> Surfaces of the format can only be sampled from but not render to.
> >
> > Does the usage of this format in Android really not allow for binding as
> > a render target?  It looks like it's exposed as a visual, so I would
> > expect it to get used as a render target.
> 2D apps can render to buffers in that format.  It is just Mesa that
> never reports an EGLConfig using the format when i915/i965 is in use.

Oh, I think I see: if the rgba_masks from droid_add_configs_for_visuals
doesn't match the driver-exposed masks for the config, then
dri2_add_config fails.  So, the list of visuals in platform_android.c
doesn't actually mean the list of configs that get exposed.

> But we still allow EGLImageKHR to be created from buffers in the
> format.  It can be used with glEGLImageTargetTexture2D and this usage
> is quite common.  But when the EGLImageKHR is used with
> glEGLImageTargetRenderbufferStorage, GL_INVALID_OPERATION should be
> generated (which I missed).

OK, if that's true then I think this patch is:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110902/a9069d73/attachment.pgp>