[Mesa-dev] [PATCH 02/10] i965/vs: Fix gen4 comparisons used for predication.
Eric Anholt
eric at anholt.net
Fri Sep 2 18:37:12 PDT 2011
When we tried to retype a brw_null_reg() in CMP(), the retyping didn't
take effect because HW_REG just ignores the type field.
---
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
index 2393a42..0e75578 100644
--- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
+++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
@@ -203,8 +203,11 @@ vec4_visitor::CMP(dst_reg dst, src_reg src0, src_reg src1, uint32_t condition)
* before before comparison, producing garbage results for floating
* point comparisons.
*/
- if (intel->gen == 4)
+ if (intel->gen == 4) {
dst.type = src0.type;
+ if (dst.file == HW_REG)
+ dst.fixed_hw_reg.type = dst.type;
+ }
inst = new(mem_ctx) vec4_instruction(this, BRW_OPCODE_CMP, dst, src0, src1);
inst->conditional_mod = condition;
--
1.7.5.4
More information about the mesa-dev
mailing list