[Mesa-dev] [PATCH] intel: fix build error

Eugeni Dodonov eugeni at dodonov.net
Sat Sep 3 08:47:23 PDT 2011


On Sat, Sep 3, 2011 at 11:29, Liu Aleaxander <aleaxander at gmail.com> wrote:

> On Sat, Sep 3, 2011 at 10:24 PM, Paul Berry <stereotype441 at gmail.com>
> wrote:
> > On 3 September 2011 07:07, Liu Aleaxander <aleaxander at gmail.com> wrote:
> >>
> >> From f02de851ba728642e26cce6fe76e5482619813e7 Mon Sep 17 00:00:00 2001
> >> From: Yuanhan Liu <yuanhan.liu at linux.intel.com>
> >> Date: Sun, 4 Sep 2011 06:02:14 +0800
> >> Subject: [PATCH] intel: fix build error
> >>
> >> Fix a build error introduced by commit 6862b54f:
> >> i965_dri.so.tmp: undefined reference to `strerr'
> >>
> >> Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
> >> ---
> >>  src/mesa/drivers/dri/intel/intel_batchbuffer.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/src/mesa/drivers/dri/intel/intel_batchbuffer.c
> >> b/src/mesa/drivers/dri/intel/intel_batchbuffer.c
> >> index c4bb836..98ae4e9 100644
> >> --- a/src/mesa/drivers/dri/intel/intel_batchbuffer.c
> >> +++ b/src/mesa/drivers/dri/intel/intel_batchbuffer.c
> >> @@ -138,7 +138,7 @@ do_flush_locked(struct intel_context *intel)
> >>    }
> >>
> >>    if (ret != 0) {
> >> -      fprintf(stderr, "intel_do_flush_locked failed: %s\n",
> strerr(ret));
> >> +      fprintf(stderr, "intel_do_flush_locked failed: %s\n",
> >> strerror(ret));
> >>       exit(1);
> >>    }
> >>    intel->vtbl.new_batch(intel);
> >> --
> >> 1.7.3.1
> >> _______________________________________________
> >> mesa-dev mailing list
> >> mesa-dev at lists.freedesktop.org
> >> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
> > I was just about to start tracking down this failure.  Thanks.
> >
> > Reviewed-by: Paul Berry <stereotype441 at gmail.com>
> >
> > I'm guessing you don't have commit access since I don't see your name in
> the
> > commit history, so I'll go ahead and push the patch.
>
> Yes, please.
>

Thanks - I fixed this locally but forgot to push yesterday.

This serves as a mental note to myself that even one-line patches could go
wrong :(. Sorry.

-- 
Eugeni Dodonov
http://eugeni.dodonov.net/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110903/b3a8b32e/attachment.html>


More information about the mesa-dev mailing list