[Mesa-dev] GLSL builtins constant constructor

Christoph Bumiller e0425955 at student.tuwien.ac.at
Sun Sep 4 06:20:48 PDT 2011

I encountered some failures in piglit's tests of builtins because a
vector constructor that is given only 1 single argument does not
replicate the argument into the yzw components, for example:

diff --git a/src/glsl/builtins/ir/cosh b/src/glsl/builtins/ir/cosh
index 45e0ae4..8bf3ad2 100644
--- a/src/glsl/builtins/ir/cosh
+++ b/src/glsl/builtins/ir/cosh
@@ -9,21 +9,21 @@
    (signature vec2
        (declare (in) vec2 x))
-     ((return (expression vec2 * (constant vec2 (0.5))
+     ((return (expression vec2 * (constant vec2 (0.5, 0.5))
                 (expression vec2 +
                  (expression vec2 exp (var_ref x))
                  (expression vec2 exp (expression vec2 neg (var_ref
    (signature vec3
        (declare (in) vec3 x))

Should the constructors or should all the builtin files be fixed ?

More information about the mesa-dev mailing list