[Mesa-dev] [PATCH 1/4] glapi: add ARB_vertex_type_2_10_10_10_rev entrypoints.

[Eric Anholt]

On Sun,  4 Sep 2011 15:05:02 +0100, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> These are the new API entrypoints for ARB_vertex_type_2_10_10_10_rev
> extension, along with the new INT_2_10_10_10_REV enum.
> 
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> +   <function name="MultiTexCoordP1ui" offset="assign">
> +         <param name="texture" type="GLenum"/>
> +         <param name="type" type="GLenum"/>
> +         <param name="coords" type="GLuint"/>
> +    </function>

Goofy indentation here -- open and close not aligned, not aligned to
neighboring blocks.

> +
> +   <function name="MultiTexCoordP2ui" offset="assign">
> +         <param name="texture" type="GLenum"/>
> +         <param name="type" type="GLenum"/>
> +         <param name="coords" type="GLuint"/>
> +    </function>
> +
> +    <function name="MultiTexCoordP3ui" offset="assign">
> +         <param name="texture" type="GLenum"/>
> +         <param name="type" type="GLenum"/>
> +         <param name="coords" type="GLuint"/>
> +    </function>

> +    <function name="VertexAttribP1ui" offset="assign">
> +	  <param name="index" type="GLuint"/>
> +          <param name="type" type="GLenum"/>
> +          <param name="normalized" type="GLboolean"/>
> +	  <param name="value" type="GLuint"/>
> +    </function>

Weird indentation of middle params here.

> +
> +    <function name="VertexAttribP2ui" offset="assign">
> +	  <param name="index" type="GLuint"/>
> +          <param name="type" type="GLenum"/>
> +          <param name="normalized" type="GLboolean"/>
> +	  <param name="value" type="GLuint"/>
> +    </function>
> +
> +    <function name="VertexAttribP3ui" offset="assign">
> +	  <param name="index" type="GLuint"/>
> +          <param name="type" type="GLenum"/>
> +          <param name="normalized" type="GLboolean"/>
> +	  <param name="value" type="GLuint"/>
> +    </function>
> +
> +    <function name="VertexAttribP4ui" offset="assign">
> +	  <param name="index" type="GLuint"/>
> +          <param name="type" type="GLenum"/>
> +          <param name="normalized" type="GLboolean"/>
> +	  <param name="value" type="GLuint"/>
> +    </function>
> +
> +    <function name="VertexAttribP1uiv" offset="assign">
> +	  <param name="index" type="GLuint"/>
> +          <param name="type" type="GLenum"/>
> +          <param name="normalized" type="GLboolean"/>
> +	  <param name="value" type="const GLuint *"/>
> +    </function>
> +    <function name="VertexAttribP2uiv" offset="assign">
> +	  <param name="index" type="GLuint"/>
> +          <param name="type" type="GLenum"/>
> +          <param name="normalized" type="GLboolean"/>
> +	  <param name="value" type="const GLuint *"/>
> +    </function>
> +    <function name="VertexAttribP3uiv" offset="assign">
> +	  <param name="index" type="GLuint"/>
> +          <param name="type" type="GLenum"/>
> +          <param name="normalized" type="GLboolean"/>
> +	  <param name="value" type="const GLuint *"/>
> +    </function>
> +    <function name="VertexAttribP4uiv" offset="assign">
> +	  <param name="index" type="GLuint"/>
> +          <param name="type" type="GLenum"/>
> +          <param name="normalized" type="GLboolean"/>
> +	  <param name="value" type="const GLuint *"/>
> +    </function>
> +</category>

Lack of whitespace.

But other than style, I've reviewed these entrypoints against the spec,
and it'll get a:

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110905/50b01b98/attachment.pgp>