[Mesa-dev] [PATCH 2/3] glsl/builtins: Fix invalid float constant in noise4 built-in.

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/05/2011 12:24 PM, Kenneth Graunke wrote:
> This is probably wrong, but ought to replicate the existing behavior.
> I don't know what the right patch is.  Ian?

I think this is correct.  At the very least, it matches the pattern of
the vec3 and vec2 versions.

For the series:

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> Cc: Ian Romanick <idr at freedesktop.org>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/glsl/builtins/ir/noise4 |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/glsl/builtins/ir/noise4 b/src/glsl/builtins/ir/noise4
> index d0894fd..4949696 100644
> --- a/src/glsl/builtins/ir/noise4
> +++ b/src/glsl/builtins/ir/noise4
> @@ -84,9 +84,9 @@
>        (assign (x) (var_ref _p) (expression float + (var_ref p) (constant float (1559.0))) )
>  
>        (assign (x) (var_ref _x) (expression float noise(var_ref p)))
> -      (assign (x) (var_ref _y) (expression float noise(expression float + (var_ref p) (constant float (601.0 313.0 29.0 277.0)))))
> +      (assign (x) (var_ref _y) (expression float noise(expression float + (var_ref p) (constant float (601.0)))))
>        (assign (x) (var_ref _z) (expression float noise(var_ref _p)))
> -      (assign (x) (var_ref _w) (expression float noise(expression float + (var_ref _p) (constant float (601.0 313.0 29.0 277.0)))))
> +      (assign (x) (var_ref _w) (expression float noise(expression float + (var_ref _p) (constant float (601.0)))))
>  
>        (assign (x) (var_ref _r) (var_ref _x))
>        (assign (y) (var_ref _r) (var_ref _y))

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk5lQ2YACgkQX1gOwKyEAw9wWgCeOBjfu3mQGgRT+9t4rtpmiIln
ywQAoIY2Y/hx/pOG8hvqt0m+Oha5CqqR
=ZdtU
-----END PGP SIGNATURE-----