[Mesa-dev] [PATCH 07/13] r600g: fix texture array filtering

Dave Airlie airlied at gmail.com
Mon Sep 5 23:29:43 PDT 2011

On Mon, Sep 5, 2011 at 10:44 PM, Marek Olšák <maraeo at gmail.com> wrote:
> This fixes piglit/fbo-generatemipmap-array.
> It looks like SQ_TEX_SAMPLER_WORD0_0.TEX_ARRAY_OVERRIDE should be set
> for array textures in order to disable filtering between slices,
> which adds a dependency between sampler views and sampler states.
> This patch reworks sampler state updates such that they are postponed until
> draw time. TEX_ARRAY_OVERRIDE is updated according to bound sampler views.
> This also consolidates setting the texture state between vertex and
> pixel shaders.

Have you measured the impact of this on framerate? I spent a lot of
time making sure we didn't do things in the draw_vbo path that we
didn't need to.

It might be better to attempt these sort of updates at bind time if we
can, even if its a bit uglier, though hopefully the dirty flag
mitigates this I'd rather know for sure.


More information about the mesa-dev mailing list