[Mesa-dev] nvfx assertion and XvMC state tracker.

[Younes Manton]

On Mon, Sep 5, 2011 at 11:35 PM, Andrew Randrianasulu
<randrianasulu at gmail.com> wrote:
> Hello.
>
> Just tested http://repo.or.cz/w/mesa/nouveau-pmpeg.git/ (commit
> 25363beccacc70a514045283bbe14951262f7b1f, "nouveau video fixup") with my nv43.
>
> At first, i got only nv40_fragtex.c:50: nv40_sampler_view_init: Assertion
> `tf->fmt[4] >= 0' failed. Then I disabled this assertion, and got some
> purple/black/green image, and few messages in dmesg from PMPEG. Not sure why
> this assertion was put here in the first place, anyone know?

To alert you to the fact that you're using an unhandled format.

> very simple hack:
>
> diff --git a/src/gallium/drivers/nvfx/nv40_fragtex.c
> b/src/gallium/drivers/nvfx/nv40_fragtex.c
> index 563183d..1353280 100644
> --- a/src/gallium/drivers/nvfx/nv40_fragtex.c
> +++ b/src/gallium/drivers/nvfx/nv40_fragtex.c
> @@ -47,7 +47,7 @@ nv40_sampler_view_init(struct pipe_context *pipe,
>        struct nvfx_texture_format *tf = &nvfx_texture_formats[sv->base.format];
>        unsigned txf;
>        unsigned level = pt->target == PIPE_TEXTURE_CUBE ? 0 :
> sv->base.u.tex.first_level;
> -       assert(tf->fmt[4] >= 0);
> +//     assert(tf->fmt[4] >= 0);
>
>        txf = sv->u.init_fmt;
>        txf |= 0x8000;
>
> XVMC_VL=1 doesn't work for me, but last I hear it has problems even with nv50.

Has no hope of working on nvfx so don't even bother, since the shader
based decoding was changed to use instance_id and branching, which are
unsupported by the hardware.