[Mesa-dev] Mesa (master): mesa/vbo: s/inline/INLINE/

[Jose Fonseca]

----- Original Message -----
> On 09/07/2011 09:40 AM, Eric Anholt wrote:
> > On Tue,  6 Sep 2011 21:45:29 -0700 (PDT),
> > vlee at kemper.freedesktop.org (Vinson Lee) wrote:
> >> Module: Mesa
> >> Branch: master
> >> Commit: 6edef25a4b41583e1c285653fc0b84a316e9743d
> >> URL:
> >>    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6edef25a4b41583e1c285653fc0b84a316e9743d
> >>
> >> Author: Vinson Lee<vlee at vmware.com>
> >> Date:   Tue Sep  6 21:43:51 2011 -0700
> >>
> >> mesa/vbo: s/inline/INLINE/
> >>
> >> MSVC does not support inline keyword.
> >
> > Could you just put #define inline<whatever>  in compiler.h for
> > MSVC?
> 
> If we want to use 'inline' we should be consistent and use it
> everywhere.  That would involve global s/INLINE/inline/ and updating
> the compiler.h file.  I'm not concerned about it enough to make the
> change myself.

The issue with INLINE is that many IDEs don't recognize, so fail to parse C++ code / declarations correctly, breaking code navigation and syntax highlighting.

I don't wanna polute the code with s/INLINE/inline/ neither, but it would be good to start migrating.  So attached is a patch that defines INLINE in terms of inline, hence guarantees that both are available everywhere.

Is this OK?

Jose
-------------- next part --------------
A non-text attachment was scrubbed...
Name: inline.diff
Type: text/x-patch
Size: 5605 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110907/77a7dee1/attachment.bin>