[Mesa-dev] Mesa (master): mesa/vbo: s/inline/INLINE/

Ian Romanick idr at freedesktop.org
Wed Sep 7 14:49:04 PDT 2011

Hash: SHA1

On 09/07/2011 10:44 AM, Jose Fonseca wrote:
> ----- Original Message -----
>> On 09/07/2011 09:40 AM, Eric Anholt wrote:
>>> On Tue,  6 Sep 2011 21:45:29 -0700 (PDT),
>>> vlee at kemper.freedesktop.org (Vinson Lee) wrote:
>>>> Module: Mesa
>>>> Branch: master
>>>> Commit: 6edef25a4b41583e1c285653fc0b84a316e9743d
>>>> URL:
>>>>    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6edef25a4b41583e1c285653fc0b84a316e9743d
>>>> Author: Vinson Lee<vlee at vmware.com>
>>>> Date:   Tue Sep  6 21:43:51 2011 -0700
>>>> mesa/vbo: s/inline/INLINE/
>>>> MSVC does not support inline keyword.
>>> Could you just put #define inline<whatever>  in compiler.h for
>>> MSVC?
>> If we want to use 'inline' we should be consistent and use it
>> everywhere.  That would involve global s/INLINE/inline/ and updating
>> the compiler.h file.  I'm not concerned about it enough to make the
>> change myself.
> The issue with INLINE is that many IDEs don't recognize, so fail to parse C++ code / declarations correctly, breaking code navigation and syntax highlighting.
> I don't wanna polute the code with s/INLINE/inline/ neither, but it would be good to start migrating.  So attached is a patch that defines INLINE in terms of inline, hence guarantees that both are available everywhere.
> Is this OK?

I've never been a fan of making up new keywords or types for "portability."

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/


More information about the mesa-dev mailing list