[Mesa-dev] [PATCH 10/20] intel: Silence several "warning: unused parameter"

Eric Anholt eric at anholt.net
Thu Sep 8 13:15:00 PDT 2011

On Mon, 29 Aug 2011 14:59:00 -0700, "Ian Romanick" <idr at freedesktop.org> wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> The internalFormat, format, and type parameters were not used by
> either try_pbo_upload or try_pbo_zcopy, so remove them.  The width
> parameter was also not used by try_pbo_zcopy (because it doesn't
> actually copy anything), so remove it too.

The current structure of this code is so hateful I can't bring myself to
say anything about whether changing the current code is good or bad.

I have a dream that one call would try to make a surface
(miptree/region) out of the PBO, then we'd see about whether it matches
up nicely and zero-copy/blit using that.  That would be reusable for
texsubimage, which is currently awful in this respect.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110908/952db742/attachment.pgp>

More information about the mesa-dev mailing list