[Mesa-dev] [PATCH] gallium: move clear paths from rgba to a pointer to a color union

[Dave Airlie]

On Thu, Sep 15, 2011 at 3:17 PM, Jose Fonseca <jfonseca at vmware.com> wrote:
> The interpretation of pipe_color_union depends on state which is not readily available (IIUC, it depends on the pipe format of the respective color rendertarget).  I think this is recipe for a lot of bugs.

Apart from u_blitter you should have the surface passes in the clear.
clear color should be opaque data until someone has to interpret it.

I'm going to fix u_blitter when I had integer clear support to it.


> c) simply use double[4] for colors (and when int64 comes along, just use long double double).

Maybe, though it seems like overkill. As I said it should be opaque
until someone decides to interpret it and when they decide to
interpret it they should have the format for the surface it
corresponds to.

You can't use integer clear values on non-integer surfaces.

Dave.