[Mesa-dev] [PATCH 2/2] softpipe: fix blending for luminance/intensity surfaces

[Brian Paul]

On 09/15/2011 02:24 PM, Marek Olšák wrote:
> On Thu, Sep 15, 2011 at 5:38 PM, Brian Paul<brian.e.paul at gmail.com>  wrote:
>> From: Brian Paul<brianp at vmware.com>
>>
>> If we're drawing to a luminance, luminance/alpha or intensity surface
>> we have to adjust (rebase) the fragment/quad colors before writing them
>> to the tile cache.  The tile cache always stores RGBA colors but if
>> we're caching a L/A surface (for example) we need to be sure that R=G=B
>> so that subsequent reads from the surface cache appear to return L/A
>>
>> We previously had a special case for RGB (no alpha) surfaces.  This
>> change generalizes that for the other base formats.
>>
>> Fixes https://bugs.freedesktop.org/show_bug.cgi?id=40408, but sRGB
>> formats are still failing.  That'll be addressed in a later patch.
>
> The fbo-blending-formats test isn't complete for sRGB yet and it's not
> in all.tests for the very same reason. It might work with
> GL_FRAMEBUFFER_SRGB disabled though, not sure.

Yeah, I looked at fbo-blending-formats and there's no sign of it 
groking sRGB.  It would be nice if the test would skip the srgb 
formats until they're properly tested as I often run it manually and 
would rather not see the invalid failures.

-Brian