[Mesa-dev] [PATCH 1/2] Gallium: remove unnecessary ifdef for MAX_CLIPPED_VERTICES.

[Brian Paul]

On 09/15/2011 03:55 PM, Paul Berry wrote:
> draw_pipe_clip.c contained an ifdef to ensure that its local
> definition of MAX_CLIPPED_VERTICES would not take effect if the global
> MAX_CLIPPED_VERTICES (defined in src/mesa/main/config.h) was already
> defined.  This was unnecessary because draw_pipe_clip.c doesn't
> directly or indirectly include src/mesa/main/config.h.  Removed the
> ifdef to reduce confusion.
> ---
>   src/gallium/auxiliary/draw/draw_pipe_clip.c |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/auxiliary/draw/draw_pipe_clip.c b/src/gallium/auxiliary/draw/draw_pipe_clip.c
> index b49502c..e1eabe2 100644
> --- a/src/gallium/auxiliary/draw/draw_pipe_clip.c
> +++ b/src/gallium/auxiliary/draw/draw_pipe_clip.c
> @@ -49,9 +49,7 @@
>   #define DIFFERENT_SIGNS(x, y) ((x) * (y)<= 0.0F&&  (x) - (y) != 0.0F)
>   #endif
>
> -#ifndef MAX_CLIPPED_VERTICES
>   #define MAX_CLIPPED_VERTICES ((2 * (6 + PIPE_MAX_CLIP_PLANES))+1)
> -#endif

For the series:

Reviewed-by: Brian Paul <brianp at vmware.com>

BTW, the #ifndef tests around DIFFERENT_SIGNS(), etc. could probably 
be removed, but it's not urgent.

-Brian