[Mesa-dev] [PATCH 1/2] i965: Add missing _NEW_POLYGON flag to polygon stipple upload.

Kenneth Graunke kenneth at whitecape.org
Mon Sep 19 11:23:43 PDT 2011


On 09/19/2011 09:31 AM, Eric Anholt wrote:
> Because we skip the pattern upload when stippling is disabled, we need
> to check again when it might have been turned on.
> ---
>   src/mesa/drivers/dri/i965/brw_misc_state.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c
> index f7e6e7c..0807554 100644
> --- a/src/mesa/drivers/dri/i965/brw_misc_state.c
> +++ b/src/mesa/drivers/dri/i965/brw_misc_state.c
> @@ -450,6 +450,7 @@ static void upload_polygon_stipple(struct brw_context *brw)
>      struct gl_context *ctx =&brw->intel.ctx;
>      GLuint i;
>
> +   /* _NEW_POLYGON */
>      if (!ctx->Polygon.StippleFlag)
>         return;
>
> @@ -479,7 +480,8 @@ static void upload_polygon_stipple(struct brw_context *brw)
>
>   const struct brw_tracked_state brw_polygon_stipple = {
>      .dirty = {
> -      .mesa = _NEW_POLYGONSTIPPLE,
> +      .mesa = (_NEW_POLYGONSTIPPLE |
> +	       _NEW_POLYGON),
>         .brw = BRW_NEW_CONTEXT,
>         .cache = 0
>      },

For the series (Eric's patches 1 and 2):
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list