[Mesa-dev] [PATCH] mesa: fix error handling for glMaterial*

Brian Paul brianp at vmware.com
Tue Sep 20 07:06:11 PDT 2011


On 09/19/2011 11:32 PM, Yuanhan Liu wrote:
> Trigger GL_INVALID_ENUM error if the face paramter is not a valid value.
>
> Trigger GL_INVALID_VALUE error if the GL_SHININESS value is out side
> [0, ctx->Constant.MaxShiniess].
>
> v2: fix the max shininess value.
>
> v3: suggested by Brian, move the face check into glMaterialfv function
>      to reduce code duplicate. Also, refactor the error message.
>
> Signed-off-by: Yuanhan Liu<yuanhan.liu at linux.intel.com>

Pushed.  Thanks.

-Brian



More information about the mesa-dev mailing list