[Mesa-dev] [PATCH 1/5] glsl: Move get_error_instruction() from ir_call to ir_constant.

Eric Anholt eric at anholt.net
Wed Sep 21 10:21:19 PDT 2011

On Tue, 20 Sep 2011 18:28:15 -0700, Kenneth Graunke <kenneth at whitecape.org> wrote:
> All this does is generate a bogus value with error type; the fact that
> it was in ir_call was rather arbitrary to begin with. ir_constant is an
> equally arbitrary place. The rationale is that a future commit will
> change ir_calls from rvalues to statements, and all uses of this
> function expect an rvalue.

This would make a lot more sense to me as a global
"get_error_rvalue(ctx)" instead of a method of some arbitrary class.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110921/460e399b/attachment.pgp>

More information about the mesa-dev mailing list