[Mesa-dev] [RFC PATCH] automake: add support to src/glsl/

[Matt Turner]

On Sun, Sep 25, 2011 at 3:06 PM, Gaetan Nadon <memsize at videotron.ca> wrote:
> I had a quick look, configure.ac is huge and has a big impact on Makefiles.
> I think it should be reviewed and cleaned-up to understand how it affects
> makefiles.
>
> Just a few examples of statements to investigate. Not that they are bad, but
> they may be needed because there was no automake and they could possibly
> conflict.
>
> AC_CHECK_PROGS([MAKE], [gmake make])
>
> AC_PATH_PROG([MKDEP], [makedepend])
>     Can 'makedepend' impact the dependencies automake generates?

It doesn't look like it affects anything in src/glsl/, at least.

> AC_PATH_PROG([FLEX], [flex])
> AC_PATH_PROG([BISON], [bison])
>     Some platforms have different names. The rules in the automake make file
> may not work if configure.ac does not use AC_PROG_YACC and AC_PROG_LEX
> This is the configuration in xorg:
>
> AC_PROG_YACC
> AC_PATH_PROG([YACC_INST], $YACC)
> if test ! -f "$srcdir/gram.c"; then
>    if test -z "$YACC_INST"; then
>       AC_MSG_ERROR([yacc not found - unable to compile gram.y])
>    fi
> fi
> AC_PROG_LEX

Probably a good idea. Should the same thing done for $YACC be done for $LEX?

> test "x$INSTALL" = "x$ac_install_sh" && INSTALL='$(MINSTALL)'
>     On some platforms, this may result in a different install program being
> used whether the makefile is from mesa or automake.

Maybe you understand the reason for that better than I do:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=bc302b2a33ceffe454bcf443daa0ac1edc118e9b

> There is a 'configuration' file. How will the automake makefiles take that
> into account.

I would think the configs/autoconf file is something we'd kill off
after the last static Makefile is gone.

> It looks like there are 'conflicts' between mesa makefiles and automake
> which is expected due to the size of the project. Some preparation work
> should be done upfront to make both system coexist and then have automake
> gradually replace mesa makefiles. This would be useful work anyway.

There's definitely some clean ups to be done, that's for sure.

Matt