[Mesa-dev] [PATCH] intel: fix potential segfault error at intel_(un)map_texture_image

Yuanhan Liu yuanhan.liu at linux.intel.com
Sun Sep 25 17:59:16 PDT 2011


On Fri, Sep 23, 2011 at 10:06:52AM -0700, Eric Anholt wrote:
> On Thu, 15 Sep 2011 16:02:49 +0800, Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote:
> > intel_image->mt might be NULL, say with border width set. It then would
> > trigger a segfault at intel_map/unmap_texture_image function.
> > 
> > This would fix the oglc misctest(basic.textureBorderIgnore) fail.
> > 
> > Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
> 
> Oops, never saw this, and sent a version of it out yesterday myself.
> 
> You shouldn't need the ->region check, since we shouldn't ever have a
> miptree without one.  Other than that, go ahead and push.

Got it. Thanks.




More information about the mesa-dev mailing list