[Mesa-dev] [PATCH 1/7] i965: Use 4 bits to store nr_userclip in brw_clip.h.

[Paul Berry]

On 26 September 2011 15:09, Kenneth Graunke <kenneth at whitecape.org> wrote:

> On 09/25/2011 09:21 AM, Paul Berry wrote:
> > Since the i965 driver supports 8 clipping planes now, we need 4 bits
> > to store the number of user clipping planes, not 3.
> >
> > In theory this isn't strictly necessary, since brw_clip.h is only used
> > on pre-GEN6, and pre-GEN6 only advertises support for 6 clipping
> > planes, but it seems wise to err on the safe side.
>
> Patches 1, 3, 5, 6, and 7 (the easy ones) are
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
>
> I still need to read 2 and 4.
>

Thanks, Ken.  I'll make the change you suggested on patch 1.  I look forward
to hearing your comments on patches 2 and 4--those are definitely the meaty
ones from this series.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110927/7790d2cf/attachment.htm>