[Mesa-dev] [PATCH 2/7] glsl: Fix assertion checking types of constant bitshift expressions.

Eric Anholt eric at anholt.net
Tue Sep 27 15:08:36 PDT 2011


Bitshifts are one of the rare places that GLSL allows mixed base types
without an implicit conversion occurring.
---
 src/glsl/ir_constant_expression.cpp |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_constant_expression.cpp
index f0299a2..56a4237 100644
--- a/src/glsl/ir_constant_expression.cpp
+++ b/src/glsl/ir_constant_expression.cpp
@@ -69,7 +69,9 @@ ir_expression::constant_expression_value()
    }
 
    if (op[1] != NULL)
-      assert(op[0]->type->base_type == op[1]->type->base_type);
+      assert(op[0]->type->base_type == op[1]->type->base_type ||
+	     this->operation == ir_binop_lshift ||
+	     this->operation == ir_binop_rshift);
 
    bool op0_scalar = op[0]->type->is_scalar();
    bool op1_scalar = op[1] != NULL && op[1]->type->is_scalar();
-- 
1.7.5.4



More information about the mesa-dev mailing list