[Mesa-dev] [PATCH] mesa: Remove unused tnl items from dd_functions

Ian Romanick idr at freedesktop.org
Fri Sep 30 12:44:24 PDT 2011


On 09/30/2011 10:45 AM, Chad Versace wrote:
> Remove NeedValidate and ValidateTnlModule.
>
> Signed-off-by: Chad Versace<chad at chad-versace.us>

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

Hurray for not being locked into a fixed core/driver interface!

> ---
>   src/mesa/drivers/common/driverfuncs.c |    2 --
>   src/mesa/main/dd.h                    |   19 -------------------
>   2 files changed, 0 insertions(+), 21 deletions(-)
>
> diff --git a/src/mesa/drivers/common/driverfuncs.c b/src/mesa/drivers/common/driverfuncs.c
> index 3e28969..33da934 100644
> --- a/src/mesa/drivers/common/driverfuncs.c
> +++ b/src/mesa/drivers/common/driverfuncs.c
> @@ -200,8 +200,6 @@ _mesa_init_driver_functions(struct dd_function_table *driver)
>      _mesa_init_sampler_object_functions(driver);
>
>      /* T&L stuff */
> -   driver->NeedValidate = GL_FALSE;
> -   driver->ValidateTnlModule = NULL;
>      driver->CurrentExecPrimitive = 0;
>      driver->CurrentSavePrimitive = 0;
>      driver->NeedFlush = 0;
> diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h
> index 720e4f5..1ccba50 100644
> --- a/src/mesa/main/dd.h
> +++ b/src/mesa/main/dd.h
> @@ -815,25 +815,6 @@ struct dd_function_table {
>      /*@{*/
>
>      /**
> -    * Bitmask of state changes that require the current T&L module to be
> -    * validated, using ValidateTnlModule() below.
> -    */
> -   GLuint NeedValidate;
> -
> -   /**
> -    * Validate the current T&L module.
> -    *
> -    * This is called directly after UpdateState() when a state change that has
> -    * occurred matches the dd_function_table::NeedValidate bitmask above.  This
> -    * ensures all computed values are up to date, thus allowing the driver to
> -    * decide if the current T&L module needs to be swapped out.
> -    *
> -    * This must be non-NULL if a driver installs a custom T&L module and sets
> -    * the dd_function_table::NeedValidate bitmask, but may be NULL otherwise.
> -    */
> -   void (*ValidateTnlModule)( struct gl_context *ctx, GLuint new_state );
> -
> -   /**
>       * Set by the driver-supplied T&L engine.
>       *
>       * Set to PRIM_OUTSIDE_BEGIN_END when outside glBegin()/glEnd().



More information about the mesa-dev mailing list