[Mesa-dev] [PATCH] st/mesa: Fix uninitialized members in glsl_to_tgsi_visitor constructor.

Brian Paul brianp at vmware.com
Mon Apr 9 08:24:17 PDT 2012


On 04/08/2012 11:40 PM, Vinson Lee wrote:
> Fixes uninitialized member defects reported by Coverity.
>
> NOTE: This is a candidate for the 8.0 branch.
>
> Signed-off-by: Vinson Lee<vlee at freedesktop.org>
> ---
>   src/mesa/state_tracker/st_glsl_to_tgsi.cpp |    4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> index 6745554..ae8533e 100644
> --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> @@ -2815,6 +2815,10 @@ glsl_to_tgsi_visitor::glsl_to_tgsi_visitor()
>      indirect_addr_temps = false;
>      indirect_addr_consts = false;
>      mem_ctx = ralloc_context(NULL);
> +   ctx = NULL;
> +   prog = NULL;
> +   shader_program = NULL;
> +   options = NULL;
>   }
>
>   glsl_to_tgsi_visitor::~glsl_to_tgsi_visitor()


Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the mesa-dev mailing list