[Mesa-dev] [PATCH] Revert "shared-glapi: Convert to automake"

Chad Versace chad.versace at linux.intel.com
Tue Apr 10 15:13:34 PDT 2012


On 04/10/2012 01:13 PM, Chad Versace wrote:
> This reverts commit ca760181b4420696c7e86aa2951d7203522ad1e8.
> 
> That commit broke the Android build.  The guilty change in that commit was
> twofold. It first changed the pattern of some variable definitions, then
> made a illegal change in Android.mk
> 
> src/mapi/mapi/sources.mak
>     - FOO_FILE := bar.c
>     + FOO_FILE := $(TOP)/src/mapi/mapi/bar.c
> src/mapi/Android.mk
>     -LOCAL_SRC_FILES := $(MAPI_GLAPI_FILES)
>     +LOCAL_SRC_FILES := $(addprefix mapi/, $(MAPI_GLAPI_SOURCES))
> 
> Source filepaths in Android makefiles must be relative to the makefile.
> 
> CC: Kristian Høgsberg <krh at bitplanet.net>
> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>

Nak this patch too. Kristian and I discussed this on IRC, and
he convinced me it was a bad idea.

----
Chad Versace
chad.versace at linux.intel.com


More information about the mesa-dev mailing list