[Mesa-dev] [PATCH 05/21] u_vbuf: override set_index_buffer

[Brian Paul]

On Wed, Apr 11, 2012 at 9:38 AM, Marek Olšák <maraeo at gmail.com> wrote:
> This makes u_vbuf_mgr call the driver instead of the other way around.
> ---
>  src/gallium/auxiliary/util/u_vbuf.c          |   35 ++++++++++++++++++++++---
>  src/gallium/auxiliary/util/u_vbuf.h          |    6 ----
>  src/gallium/drivers/r300/r300_context.h      |    2 +-
>  src/gallium/drivers/r300/r300_render.c       |   22 ++++++++--------
>  src/gallium/drivers/r300/r300_state.c        |   15 +++++------
>  src/gallium/drivers/r600/r600_pipe.h         |    1 +
>  src/gallium/drivers/r600/r600_state_common.c |   16 +++++++----
>  7 files changed, 60 insertions(+), 37 deletions(-)


I looked at patches 5-16 and they seem OK to me but someone more
familiar with r300 might want to double-check.

In the patch where you add the new gallium PIPE_CAP_ tokens, you're
using "DWORD".  I think that's the first occurrence of that term in
the gallium interface.

Coming from a workstation-centric background I've never been a big fan
of dword since I always thought of a word as being 32-bits.  Would
something like "4BYTE" be acceptable in this case?  I guess it's not a
big deal though.

-Brian