[Mesa-dev] [PATCH] ir_to_mesa: Fix uninitialized member in add_uniform_to_shader.

[Brian Paul]

On 04/12/2012 12:11 AM, Vinson Lee wrote:
> Fix uninitialized scalar field defect reported by Coverity.
>
> NOTE: This is a candidate for the 8.0 branch.
>
> Signed-off-by: Vinson Lee<vlee at freedesktop.org>
> ---
>   src/mesa/program/ir_to_mesa.cpp |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp
> index 6f4a095..840648e 100644
> --- a/src/mesa/program/ir_to_mesa.cpp
> +++ b/src/mesa/program/ir_to_mesa.cpp
> @@ -2358,7 +2358,7 @@ class add_uniform_to_shader : public uniform_field_visitor {
>   public:
>      add_uniform_to_shader(struct gl_shader_program *shader_program,
>   			 struct gl_program_parameter_list *params)
> -      : shader_program(shader_program), params(params)
> +      : shader_program(shader_program), params(params), idx(-1)
>      {
>         /* empty */
>      }

Looks OK to me.  Reviewed-by: Brian Paul <brianp at vmware.com>