[Mesa-dev] [PATCH 02/10] glsl: Use the column_types() helper method.

Eric Anholt eric at anholt.net
Mon Apr 16 16:59:46 PDT 2012


Ken noted this in a review of this patch that I pushed early.
---
 src/glsl/opt_array_splitting.cpp |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/glsl/opt_array_splitting.cpp b/src/glsl/opt_array_splitting.cpp
index f11b516..e41818f 100644
--- a/src/glsl/opt_array_splitting.cpp
+++ b/src/glsl/opt_array_splitting.cpp
@@ -348,8 +348,7 @@ optimize_split_arrays(exec_list *instructions, bool linked)
       const struct glsl_type *subtype;
 
       if (type->is_matrix())
-	 subtype = glsl_type::get_instance(GLSL_TYPE_FLOAT,
-					   type->vector_elements, 1);
+	 subtype = type->column_type();
       else
 	 subtype = type->fields.array;
 
-- 
1.7.10



More information about the mesa-dev mailing list