[Mesa-dev] [PATCH 1/2] r600g/automake: add $CFLAGS and $OPT_FLAGS

[Tom Stellard]

On Thu, Apr 19, 2012 at 04:56:44AM +0200, Marek Olšák wrote:
> I didn't check any other drivers besides r300g. I hope CFLAGS is not the only
> variable containing the -O2 flag...
> ---
>  src/gallium/drivers/r600/Makefile.am |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/src/gallium/drivers/r600/Makefile.am b/src/gallium/drivers/r600/Makefile.am
> index 8acd36a..431dea0 100644
> --- a/src/gallium/drivers/r600/Makefile.am
> +++ b/src/gallium/drivers/r600/Makefile.am
> @@ -7,9 +7,11 @@ AM_CFLAGS = \
>  	-I$(top_srcdir)/src/gallium/auxiliary \
>  	-I$(top_srcdir)/src/gallium/drivers \
>  	-I$(top_srcdir)/include \
> +	$(CFLAGS) \
>  	$(RADEON_CFLAGS) \
>  	$(DEFINES) \
>  	$(ASM_FLAGS) \
> +	$(OPT_FLAGS) \
>  	$(PIC_FLAGS) \
>  	$(VISIBILITY_CFLAGS)
>  
> -- 
> 1.7.5.4
> 

$(CFLAGS) is not needed here, and we should add $(ARCH_FLAGS) to
this list as well.  With these changes both patches are:

Reviewed-by: Tom Stellard <thomas.stellard at amd.com>

> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>